fix(nuemark2): line splitting, import, undefined blocks #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobkd
changed the title
|
Thanks! |
|
I'm not sure about those routing tests whether they do the best job at finding issues: slow, complex and error-prone. I'd like to find a simpler alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
EOLfromnode:osdoes not work for splitting a file on line-endings, becauseEOLis\non Mac/Linux and\r\non Windows. BUT files ´on Windows can also just use\nline endings, as Windows can also handle those.The package from npm is named
nue-glownotglow(and should also have this name in your local installation)When I ran
bun testtheblockvariable was undefined and some test errored on unpacking.(There are still routing tests failing, idk why, but I currently don't care about them.)