fix: replace cr and crlf with lf, split on all line endings #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Maybe the complex line ending could be a constant? |
|
Yeah, maybe. But would have to be per package to prevent unnecessary dependencies. |
|
Good point. This is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to replace / split as early as needed, to keep the replace / split changes small.
I also tried checking for places where functions get exported.
Changed in all packages for standalone use.
Added a test, that might not catch everything, but that's probably okay.
The change in
packages/nuekit/src/builder.jswill probably be different when #278 is merged.