Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(code-block): add test for html text escaping #172

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Jan 18, 2024

Follow up to #169

I forgot to add a test, so...
Just a simple test to ensure, that escaping is performed properly for code blocks.


Just a question: Shouldn't fenced code blocks be structured like this?

<pre>
  <code>
  // My code
  </code>
</pre>

Because currently, it just consists of a <pre>-tag. And I also only know it the way from my example.

@tipiirai tipiirai merged commit 83e96ac into nuejs:master Jan 22, 2024
@tipiirai
Copy link
Contributor

Thanks!

@nobkd nobkd deleted the patch-1 branch January 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants