Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix TypeError with EventEmitter#on() abuse #527

Merged
merged 3 commits into from
Jan 20, 2015
+17 −134
Merged

lib: fix TypeError with EventEmitter#on() abuse #527

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
767ee73
test: strip copyright boilerplate
bnoordhuis Jan 20, 2015
77d6807
test: fix event-emitter-get-max-listeners style
bnoordhuis Jan 20, 2015
ee9cd00
lib: fix TypeError with EventEmitter#on() abuse
bnoordhuis Jan 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix event-emitter-get-max-listeners style 
Add missing commas in parallel/test-event-emitter-get-max-listeners.

Comma-less style is fine and dandy but it throws off vim's autoindent.

PR-URL: #527
Reviewed-By: Colin Ihrig <[email protected]>
@bnoordhuis
bnoordhuis committed Jan 20, 2015
commit 77d68070dafe56b5593ad92759a57c64de6b4cf1
8 changes: 4 additions & 4 deletions test/parallel/test-event-emitter-get-max-listeners.js
View file
Original file line number Diff line number Diff line change
@@ -6,8 +6,8 @@ var emitter = new EventEmitter();

assert.strictEqual(emitter.getMaxListeners(), EventEmitter.defaultMaxListeners);

emitter.setMaxListeners(0)
assert.strictEqual(emitter.getMaxListeners(), 0)
emitter.setMaxListeners(0);
assert.strictEqual(emitter.getMaxListeners(), 0);

emitter.setMaxListeners(3)
assert.strictEqual(emitter.getMaxListeners(), 3)
emitter.setMaxListeners(3);
assert.strictEqual(emitter.getMaxListeners(), 3);