rbd: format log message correctly

When a `dataPool` is passed while creating a volume, there is a `%!s(MISSING)` piece added to a debug log message. By using `fmt.Sprintf()` instead of concatinating the string, this should be gone now. Updates: ceph#5103 Signed-off-by: Niels de Vos <[email protected]>
nixpanic · Jan 30, 2025 · d477f60 · d477f60
1 parent 72cfaaf
commit d477f60
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/rbd/rbd_util.go b/internal/rbd/rbd_util.go
@@ -1586,7 +1586,7 @@ func (rv *rbdVolume) constructImageOptions(ctx context.Context) (*librbd.ImageOp
 
 	logMsg := fmt.Sprintf("setting image options on %s", rv)
 	if rv.DataPool != "" {
-		logMsg += ", data pool %s" + rv.DataPool
+		logMsg += fmt.Sprintf(", data pool %s", rv.DataPool)
 		err = options.SetString(librbd.RbdImageOptionDataPool, rv.DataPool)
 		if err != nil {
 			return nil, fmt.Errorf("failed to set data pool: %w", err)