Redirect to onboard when the user has no wallets #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o sign a message instead of just showing empty list
sisou
reviewed
Jan 20, 2025
Comment on lines
+117
to
+119
| if (this.isSecondaryOnboarding | ||
| // In the case we don't have wallets while signing a message, we close the hub | ||
| && (this.originalRouteName !== RequestType.SIGN_MESSAGE || this.hasWallets)) { |
There was a problem hiding this comment.
I don't understand this condition and the comment. The comment talks about not having wallets, but the check is for having wallets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect to onboard when the user has no wallets connected and want to sign a message instead of just showing empty list