-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade qdownload to iqfeed 6.2 #7
base: master
Are you sure you want to change the base?
Conversation
Thanks for your PR, great upgrading to the latest protocol! I don't use IQFeed currently so I cannot test your changes unfortunately. Can you look at the failing tests? |
|
Hi, updated the failed tests, could you approve the workflow unittest? |
I added a couple of questions inline during my review, maybe you did not see them? |
Aha didn't see that |
Could you hint where I can see your inline questions? Looking at the Files changed shows no comments. |
Wow it seems Github has issues showing inline code comments: https://github.com/orgs/community/discussions/30638 |
I am copying the comments here instead: main.go 181 main.go 216 iqfeed.go 114 |
main.go> Thank you, will try collecting the errors I got that motivated me to add this code. iqfeed.go> I assumed the TCP-connections are separate and thus the data doesn't get scrambled. Will have to more properly test this. |
Hello,
I took the liberty to upgrade your qdownload tool from iqfeed protocol 5.1 to the latest 6.2 and add some small changes I thought are useful.
Changes I've done: