Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide announcement with JS if date is past #556

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 9, 2025

Use some Javascript to automatically hide the announcement banner if a specified date has passed.

Means that we can still have the banner active even in fixed statically built releases.

Downside is that there is a slight flicker on page load for the banner, I can't get around that though. I've prioritised the flicker for when it's active, vs. when it's inactive (figure it'll be inactive more of the time).

Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit 56eb95c
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/67ccef9b7822b90008ecbb04
😎 Deploy Preview https://deploy-preview-556--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@vdauwera vdauwera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdauwera vdauwera merged commit 2cd0642 into nextflow-io:master Mar 9, 2025
7 checks passed
@ewels ewels deleted the announcement_hide_after branch March 9, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants