Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devcontainers cleanup #513

Merged
merged 26 commits into from
Mar 5, 2025
Merged

Devcontainers cleanup #513

merged 26 commits into from
Mar 5, 2025

Conversation

ewels
Copy link
Member

@ewels ewels commented Feb 18, 2025 •
edited
Loading

Trying to simplify the devcontainers / dev environment setup, as well as removing Gitpod-specific stuff.

WIP, may not work. Edit: should work, I think

@ewels ewels changed the base branch from master to minor-fixes February 18, 2025 22:51
@netlify Netlify
Copy link

netlify bot commented Feb 18, 2025 •
edited
Loading

✅ Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit 0a6b45f
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/67c85bfae35b880008f2eb62
😎 Deploy Preview https://deploy-preview-513--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Base automatically changed from minor-fixes to master February 18, 2025 23:10
@ewels
Copy link
Member Author

ewels commented Feb 18, 2025

To test, go to the devcontainers-cleanup branch and create a new codespace.

You'll get a info box bottom right saying creating, click the link there to see the build log.

@ewels ewels marked this pull request as ready for review February 18, 2025 23:27
@vdauwera vdauwera added the environment Devcontainer, codespaces etc label Feb 19, 2025
@maxulysse
Copy link
Collaborator

This is looking amazing <3

@maxulysse
Copy link
Collaborator

To test, go to the devcontainers-cleanup branch and create a new codespace.

You'll get a info box bottom right saying creating, click the link there to see the build log.

works for me

maxulysse
maxulysse previously approved these changes Feb 27, 2025
View reviewed changes
@ewels ewels marked this pull request as draft February 27, 2025 17:33
@ewels

This comment was marked as resolved.

Sign in to view
@ewels ewels marked this pull request as ready for review February 28, 2025 00:01
@pinin4fjords pinin4fjords mentioned this pull request Mar 3, 2025
Closed
kenibrewer
kenibrewer approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on Phil's fork. LGTM

pinin4fjords
pinin4fjords approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@kenibrewer kenibrewer merged commit 3168758 into master Mar 5, 2025
8 checks passed
@kenibrewer kenibrewer deleted the devcontainers-cleanup branch March 5, 2025 15:28
@adamrtalbot adamrtalbot mentioned this pull request Mar 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

@kenibrewer kenibrewer kenibrewer approved these changes

@maxulysse maxulysse maxulysse left review comments

Assignees
No one assigned
Labels
environment Devcontainer, codespaces etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ewels @maxulysse @pinin4fjords @kenibrewer @vdauwera