feat(wave client): Support local manifests in FUSION_CONTAINER_CONFIG_URL
#5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…R_CONFIG_URL` Signed-off-by: Alberto Miranda <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please add some context and description |
alberto-miranda
changed the title
FUSION_CONTAINER_CONFIG_URLFUSION_CONTAINER_CONFIG_URL
Apologies @pditommaso, it wasn't my intention to create a PR yet but the cat's now out of the bag 😅 |
alberto-miranda
changed the title
FUSION_CONTAINER_CONFIG_URLFUSION_CONTAINER_CONFIG_URL
|
Description updated. |
|
Tests and docs coming only if this PR is actually useful 🤞 |
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
5a93547 to
27345a6
Compare
|
@alberto-miranda is this still valid? |
It is, but I haven't had time to finish this 😅. Feel free to do as you wish with this PR, I can always recreate it if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables Nextflow to accept local files as an additional source for
FUSION_CONTAINER_CONFIG_URL. This can be useful for testingfusionand also for offline deployments. Local files can be specified using thefile://schema or with no schema at all.