Signing node using aggregate signatures #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidM-D
requested review from
volovyks,
itegulov,
ChaoticTempest and
abacabadabacaba
|
As discussed, I'm going to pull out the submit endpoints and rework the integration tests, but everything I'll do will be removing code, no more adding. |
|
doesn't look like it's compilable. Is it working? Should I help clean it up? |
|
Sorry I rebased then didn't push up my fix. Pushed now |
itegulov
reviewed
Apr 23, 2023
volovyks
reviewed
Apr 23, 2023
Modified the test environment to expose the signing nodes so we can actually test they're signing the right payloads
|
Please merge this if you're happy with it |
Closed
ChaoticTempest
approved these changes
Apr 24, 2023
| pagoda_firebase_audience_id: String, | ||
| node_key: ExpandedKeyPair, | ||
| signing_state: Arc<RwLock<SigningState>>, |
There was a problem hiding this comment.
This could just be using a Mutex instead. There's only been writers to this state, so no need to use RwLock which is better only if we have readers away from writing logic.
There was a problem hiding this comment.
Leaving as is for now in case we need read-only access. We can clean up later if needed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working implementation of aggregate signing nodes.
Current issues are that it will merrily sign any payload you send it provided there's an oauth token and it only uses a single key.
It also breaks every integration test we have. Tomorrow morning I'm going to work on integrating it into our existing leader node calling and adding the constraints on what it signs. The test
aggregate_signaturessketches out how this will look. The leader can be very dumb as all of the validation is done on the signers side.I'd appreciate your feedback, to make sure I'm going in the right direction.