Fixing prmetheus metrics definition #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
reviewed
Sep 23, 2024
chain-signatures/node/src/metrics.rs
Outdated
| pub(crate) static NUM_SIGN_REQUESTS: Lazy<IntGaugeVec> = Lazy::new(|| { | ||
| try_create_int_gauge_vec( | ||
| "multichain_sign_requests_count", | ||
| pub(crate) static NUM_SIGN_REQUESTS_MINE: Lazy<CounterVec> = Lazy::new(|| { |
There was a problem hiding this comment.
we should not rename this
ppca
reviewed
Sep 23, 2024
| @@ -14,26 +14,26 @@ pub(crate) static NODE_RUNNING: Lazy<IntGaugeVec> = Lazy::new(|| { | |||
| .unwrap() | |||
| }); | |||
|
|
|||
| pub(crate) static NUM_SIGN_REQUESTS: Lazy<IntGaugeVec> = Lazy::new(|| { | |||
| try_create_int_gauge_vec( | |||
| pub(crate) static NUM_SIGN_REQUESTS: Lazy<CounterVec> = Lazy::new(|| { | |||
There was a problem hiding this comment.
What's the difference between CounterVec and IntGaugeVec?
There was a problem hiding this comment.
You can not go down with counter. Also, there are some inconsistencies with the data. We are trying to find the reason.
volovyks
previously approved these changes
Sep 23, 2024
volovyks
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.