add more contract api tests #794
Merged
+453
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
approved these changes
Aug 2, 2024
| /// The fee is volatile and depends on the number of pending requests. | ||
| /// If used on a client side, it can give outdate results. | ||
| pub fn experimantal_signature_deposit(&self) -> u128 { |
There was a problem hiding this comment.
Thank you! I think I've made that mistake in docs as well.
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_derived_public_key() -> anyhow::Result<()> { |
There was a problem hiding this comment.
We will need to execute actual derivation logic in such a test. Not a blocker now.
There was a problem hiding this comment.
agree. Probably good to be able to fix the pk in init_env() so we can test the value of the derived pk is correct.
|
|
||
| let key: String = contract.view("public_key").await.unwrap().json().unwrap(); | ||
|
|
||
| let execution = accounts[2] |
There was a problem hiding this comment.
We should check that random acc can not vote for pk
ppca
approved these changes
Aug 4, 2024
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_derived_public_key() -> anyhow::Result<()> { |
There was a problem hiding this comment.
agree. Probably good to be able to fix the pk in init_env() so we can test the value of the derived pk is correct.
|
@ailisp merging, lets address all the comments if a follow up PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#764