Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make override default impl return empty map and use u32 instead of usize #759

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

ChaoticTempest
Copy link
Member

fixes:

  • make override default have empty map instead of null
  • make all usize in contract/ code use u32 instead due to architectural differences

@ChaoticTempest ChaoticTempest requested review from volovyks and ppca July 30, 2024 00:51
ppca
ppca previously approved these changes Jul 30, 2024
Copy link
Contributor

@ppca ppca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChaoticTempest ChaoticTempest force-pushed the phuong/fix/usize-and-default-override branch from 3fee2dc to f92bbea Compare July 30, 2024 02:01
@ChaoticTempest ChaoticTempest merged commit 6dc7704 into develop Jul 30, 2024
4 checks passed
@ChaoticTempest ChaoticTempest deleted the phuong/fix/usize-and-default-override branch July 30, 2024 02:38
Copy link

Terraform Feature Environment Destroy (dev-759)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants