Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A collection of small audit fixes #754

Merged
merged 7 commits into from
Jul 29, 2024
Merged

A collection of small audit fixes #754

merged 7 commits into from
Jul 29, 2024

Conversation

DavidM-D
Copy link
Contributor

No description provided.

DavidM-D added 7 commits July 24, 2024 16:21
@DavidM-D
Closes #720
5868392 
Prevent overflows in the contract
@DavidM-D
Closes #741
ee4d5f5 
Put a warning on derive_epsilon
@DavidM-D
Closes #743
abcd275 
Clarify why we're removing the triples from the datastore
@DavidM-D
Closes #746
7ba1faa 
All vulnerabilities in cargo audit in chain signatures are have an
explanation as to why they're benign. This hasn't been done for
fastauth-MPC yet.
@DavidM-D
Fixed lint
2d68612
@DavidM-D
Migrate from sha2 to sha3 for deriving delta
40eabf4 
Not from our external audit, but our internal audit said this would
protect us from a key extention attack.
@DavidM-D
We don't need to audit our integration tests
4b2c5f8
@DavidM-D DavidM-D requested a review from ChaoticTempest July 29, 2024 16:31
ChaoticTempest
ChaoticTempest approved these changes Jul 29, 2024
View reviewed changes
chain-signatures/node/src/protocol/triple.rs
let triple_0 = self
.triples
.remove(&id0)
.ok_or(GenerationError::TripleIsMissing(id0))?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't hurt to add the ok_ors but we already guarantee that they exist with the previous self.triples.contains_key({id0, id1})

@ChaoticTempest ChaoticTempest merged commit 6a29456 into develop Jul 29, 2024
4 checks passed
@ChaoticTempest ChaoticTempest deleted the dmd/audit-nits branch July 29, 2024 18:31
@github-actions GitHub Actions
Copy link

Terraform Feature Environment Destroy (dev-754)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan 


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaoticTempest ChaoticTempest ChaoticTempest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidM-D @ChaoticTempest