feat: properly sandboxed integration tests #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perly-sandboxed-tests
volovyks
reviewed
Apr 19, 2023
integration-tests/tests/lib.rs
Outdated
| drop(leader_node); | ||
| drop(sign_nodes); | ||
| // drop(leader_node); | ||
| // drop(sign_nodes); | ||
| // drop(relayer); |
There was a problem hiding this comment.
I just deleted them temporarily so I could inspect the containers after the tests end, will return them back
itegulov
force-pushed
the
daniyar/properly-sandboxed-tests
branch
4 times, most recently
from
281177a to
b52c920
Compare
itegulov
force-pushed
the
daniyar/properly-sandboxed-tests
branch
from
b52c920 to
6267353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local relayer & sandbox nearcore