Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract: remove clean_payloads() and check pending request before decrement counter #697

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

ppca
Copy link
Contributor

@ppca ppca commented Jul 18, 2024

Part of addressing the audit about request counter. We should not need clean_payloads() anymore because the yield/resume will always either time out (a couple hundred blocks) or return signature, either way it will remove the request from pending_requests, so no request will be left in pending forever.

@ppca ppca changed the title contract: remove clean_payloads() contract: remove clean_payloads() and check pending request before decrement counter Jul 18, 2024
@ChaoticTempest ChaoticTempest merged commit 6404823 into develop Jul 18, 2024
4 checks passed
@ChaoticTempest ChaoticTempest deleted the xiangyi/remove_clean_payload branch July 18, 2024 21:41
Copy link

Terraform Feature Environment Destroy (dev-697)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants