-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test different resharing senarios and fix some bugs #692
Conversation
Seems the problem is more serious, log shows that new joined participants don't generate triplet at all. Still investigating |
Do you guys know why cargo check fails? There is no relevant change or ci toolchain change since last passing CI. They both use stable 1.79.0. Using stable 1.79.0 cargo check succeed locally. I found this https://users.rust-lang.org/t/time-crate-compilation-error/111789/3 but it only fails for a nightly rustc |
@ailisp We have this issue on Phuongs PR, the reason is unknown. It works on my PC and on the GCP VM. |
Terraform Feature Environment Destroy (dev-692)Terraform Initialization ⚙️
|
When test resharing I found some problem:
The root cause of 1. is the new participant has url with trailing
/
. And node pingip:port//state
(double slash) fails therefore not joining it into active participant set. Although the test infra can manage to spin up node with out trailing/
, our node should be handle this case more robustly. The fix is to replace every string url concat with Url.join.The root cause of 2. is as participant join and leave, stable participant set could be temprorailly below threshold number of participant. The fix is to wait and soon new active participant will become stable and protocol will proceed.
Also merge and improve resharing tests to test more senarios: leave, join, rejoin