Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes cases that did not need to error early in the process #634

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ChaoticTempest
Copy link
Member

@ChaoticTempest ChaoticTempest commented Jun 6, 2024

This fixes a bunch of cases where we did not need to return the error early at all and potentially roll back the state.

For example, the TripleManager::poke would return the first error, but that did not need to happen as erroring out on a triple generator should just bin the generator and not interfere with the poking of other generators.

Also adds in a check for triple_id or presignature_id collisions.

@volovyks volovyks merged commit 0a5e987 into develop Jun 6, 2024
4 checks passed
@volovyks volovyks deleted the phuong/fix/early-erroring branch June 6, 2024 13:35
Copy link

github-actions bot commented Jun 6, 2024

Terraform Feature Environment Destroy (dev-634)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @volovyks, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants