Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ci #630

Merged
merged 9 commits into from
Jun 11, 2024
Merged

Optimize ci #630

merged 9 commits into from
Jun 11, 2024

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Jun 5, 2024

Previous cache has a size limit of 10G and it is not sufficient, result in fresh build everytime. This PR uses a unlimited cache to reduce build time. In the best case where dependency crate is not changed and only our code changes, it reduce 20 minutes of build time of unit (28min -> 6min), fastauth integration (33min -> 13min) and chain signature integration tests (35min -> 16min).

@ailisp ailisp marked this pull request as ready for review June 7, 2024 05:27
@ailisp ailisp requested review from ChaoticTempest and volovyks June 7, 2024 06:54
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds great!
Is it a free solution?

Copy link
Member

@ChaoticTempest ChaoticTempest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, and I didn't know about warp builds until this PR. Looks great to add

@volovyks
Copy link
Collaborator

https://docs.warpbuild.com/runners
Looks like they have M1 machines. It can be useful for us at some point.

@ailisp ailisp merged commit db43885 into develop Jun 11, 2024
4 checks passed
@ailisp ailisp deleted the optimize-ci branch June 11, 2024 06:27
Copy link

Terraform Feature Environment Destroy (dev-630)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ailisp, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

@ailisp
Copy link
Member Author

ailisp commented Jun 11, 2024

@volovyks it's not free but quite cheap. I'll give a try on their mac m1 machines, maybe they work unlike github's

@volovyks
Copy link
Collaborator

We may need to build M1 Docker images, I'm not sure if it is required to run tests on M1 instances.

@ChaoticTempest
Copy link
Member

Don't think it would change anything though, since what was broken wasn't that we didn't have M1 docker builds but that colima (the docker virtualization tooling) was flaky on macos and we never bothered to get it working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants