-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: local build.rs not running on changes #625
Conversation
println!("cargo:rerun-if-changed=../../contract/"); | ||
println!("cargo:rerun-if-changed=../../keys/"); | ||
println!("cargo:rerun-if-changed=../../node/"); | ||
rerun_directory("../../chain-signatures/"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this result multiple rerun if more than one dir changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This build script only gets ran when you build the integration-tests package, so it'll only be ran once. The rerun_directory
just has it listens to specific timestamps for a list of directories, and if any of them changes, it'll trigger a rebuild the next time we go to build this test package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Terraform Feature Environment Destroy (dev-625)Terraform Initialization ⚙️
|
This fixes local build.rs script not running correctly due to changed folder structure. Also moved
crypto-shared
folder intochain-signatures
since that would be annoying later to deal with.