Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local build.rs not running on changes #625

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

ChaoticTempest
Copy link
Member

This fixes local build.rs script not running correctly due to changed folder structure. Also moved crypto-shared folder into chain-signatures since that would be annoying later to deal with.

println!("cargo:rerun-if-changed=../../contract/");
println!("cargo:rerun-if-changed=../../keys/");
println!("cargo:rerun-if-changed=../../node/");
rerun_directory("../../chain-signatures/");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this result multiple rerun if more than one dir changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build script only gets ran when you build the integration-tests package, so it'll only be ran once. The rerun_directory just has it listens to specific timestamps for a list of directories, and if any of them changes, it'll trigger a rebuild the next time we go to build this test package

Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChaoticTempest ChaoticTempest merged commit ac09321 into develop Jun 4, 2024
5 checks passed
@ChaoticTempest ChaoticTempest deleted the phuong/fix/builds-not-running branch June 4, 2024 04:25
Copy link

github-actions bot commented Jun 4, 2024

Terraform Feature Environment Destroy (dev-625)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants