Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store reshared key after generation #615

Merged
merged 1 commit into from
May 30, 2024

Conversation

ppca
Copy link
Contributor

@ppca ppca commented May 26, 2024

We did not store the new key share to secret manager previously, so whenever restart, we don't have the correct key share for the epoch anymore

@ppca ppca requested review from volovyks and ChaoticTempest May 26, 2024 09:12
@ppca ppca mentioned this pull request May 26, 2024
@ppca ppca linked an issue May 26, 2024 that may be closed by this pull request
@ChaoticTempest
Copy link
Member

wow, nice catch on this. Can we also add in a test (or maybe add it to already existing reshare test) to check on whether or not after resharing, we were able to store this secret value?

@ppca
Copy link
Contributor Author

ppca commented May 28, 2024

wow, nice catch on this. Can we also add in a test (or maybe add it to already existing reshare test) to check on whether or not after resharing, we were able to store this secret value?

Yep we can do that. Thanks to now we have the local disk storage secret storage option. :D

Copy link
Member

@ChaoticTempest ChaoticTempest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna merge this one for now. @ppca I'll let you add the test when you get the chance

@ChaoticTempest ChaoticTempest merged commit df5c78c into develop May 30, 2024
3 of 4 checks passed
@ChaoticTempest ChaoticTempest deleted the xiangyi/fix_store_reshared_key branch May 30, 2024 20:22
Copy link

Terraform Feature Environment Destroy (dev-615)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Real env resharing test
2 participants