Develop -> Main #298
Merged
Develop -> Main #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fn renamings
* logs added to cli
* add tracing-subscriber to integration test runner
* Added rogue key attack mitigation
* README updated, claim doc added * claim id token endpoint, request, responce, etc * fmt * basic claiming endpoint logic and integration tests added * fmt * clippy * clippy * fmt * fr test ignored * clippy * sha256 -> sha512 * sign node requests updated, signing code added in sign ndoe * digest used in signing node, unit tests added * front running integration test uncommented, errors fixed * fmt * fr test fixed * digest signature check added * clippy * TODOs updated * db code added (partially turned off) * tracing logs added to commit * sha256 * db fix * Ðutils tests extended * mpc_pk added to claiming responce * additional mpc_pk signature added * OidcDigest seiralization tests added * test_oidc_to_name test added * OidcDigest moved to it's own file * fmt * encode digest as hex * key checks added * Update mpc-recovery/src/primitives.rs Co-authored-by: Daniyar Itegulov <[email protected]> * some PR comments addressed --------- Co-authored-by: Daniyar Itegulov <[email protected]>
* outdated README info fixed * add_key replaced with sign (not tested) * README fix * adapt integration tests * README update * extended pk API (#192) * extended commit API * mpc pk endpoint used in it * user recovery pk used in tests * removed code duplication * recovery PK used in add_key, some tests fixed * tests fixed * get rid of account_lookup_url from TF * use info log level --------- Co-authored-by: Daniyar Itegulov <[email protected]>
* make proper status request to sandbox * ensure the network is created * use local address for relayer and sandbox * clarify CI workflow * print leader node logs * improve http response assertion * add logging to claim_oidc * appease clippy * get rid of ad-hoc up funding * wait until sandbox is ready * use xl runner * set higher timeout for slower machines * do not print logs by default
* outdated README info fixed * add_key replaced with sign (not tested) * README fix * adapt integration tests * README update * extended pk API (#192) * extended commit API * mpc pk endpoint used in it * user recovery pk used in tests * removed code duplication * recovery PK used in add_key, some tests fixed * tests fixed * frp parameters added to new endpoints * frp parameter added to new_account endpoint * clippy * type error fixed * oidc problem fixed * unused funtions deleted * REDME API docs updated * digest avlidation added to the signing node * frp pk added to README and structures * frp test extended * tests apdated * refactor frp test to be a little simpler * preserve sign node status code response * appease clippy * protected acc credentials (unfinished) (#204) * protected acc credentials (unfinished) * fake signature used in new_acc request * FRP user_credentials check turned off * oidc error fixed * oidc protection turned on for sign plus tests * clippy * claiming bug fixed * negative claiming test added * oidc not claimed handled as unauthorized * clippy * test fix --------- Co-authored-by: Daniyar Itegulov <[email protected]>
* tie docker image tags to git commit hash * ensure terraform workflows wait for lock * use external scripts to get git sha
* disclaimer about leader node added * FRP turned on for user credentials
* add and delete key whitelisted * Preventing recovery key deletion (#214) * preventing recovery key deletion * user credentials digest passed to the sign endpoint
* tmp * tmp2 * Added CLI::rotate_sign_node_keys & moved rotate_cipher * Fixed import * Added test for rotating node keys * Added further to test * Cleanup & Clippy * Remove dead code * Cleanup deps * remove dead code * Cleanup tests * clippy * Fix incorrect address for macos * Clippy
* tmp * tmp2 * Added CLI::rotate_sign_node_keys & moved rotate_cipher * Fixed import * Added test for rotating node keys * Added further to test * Cleanup & Clippy * Remove dead code * Cleanup deps * remove dead code * Cleanup tests * clippy * Fix incorrect address for macos * Clippy * Moved test functions over to mod.rs * Cleanup test_basic_front_running_protection * Cleanup test_random_recovery_keys * Cleanup negative_front_running_protection * clippy
* tmp * tmp2 * Added CLI::rotate_sign_node_keys & moved rotate_cipher * Fixed import * Added test for rotating node keys * Added further to test * Cleanup & Clippy * Remove dead code * Cleanup deps * remove dead code * Cleanup tests * clippy * Fix incorrect address for macos * Clippy * Moved test functions over to mod.rs * Cleanup test_basic_front_running_protection * Cleanup test_random_recovery_keys * Cleanup negative_front_running_protection * clippy * Cleanup some unnecessary clones * Remove unnecessary clones for sign_request_digest * Remove unnecessary clones for user_credentials_request_digest * Remove clone on to_string()s * Cleanup clones for .user_credentials_with_helper * Remove clone on new_account_with_helper * Cleanup clones for add_key * Cleanup misc clones * One less clone * Moved test functions over to mod.rs * Cleanup test_basic_front_running_protection * Cleanup test_random_recovery_keys * Cleanup negative_front_running_protection * clippy * Another clone cleanup * Even less clones now * Simplify call site for clones * clippy
* do not throw error when claiming the same pair of key and id token * claiming of the same token with another key prevented * usage of wrong sk prevented * clippy * old TODO deleted * clippy * typo
* Update deps * Handle json serialization error w/ StatusCode and error message * Fmt
* Make OidcVerificationFail unauthorized * Fix incorrect status code
* Make new_account request take AccountId * Correct status codes * Added FRP check to leader node side * Add comment * chore: update pk in req (#274) * Make MpcPkResponse use PublicKey type * Make FRP pk use PublicKey type over String * Make NewAccountResponse use PublicKey type over String
* 500 error messages hiden * erro codes tuned
* No longer supplying audience when verifying OIDC tokens * Cleanup OIDC decoding * Fix test * Added Firewall for protecting against unauthorized audience and issuer * Fix integration tests * Try fix infra/terraform * Try fix terraform * Fmt * Renamed allowlist to allowed oidc providers * Fix terraform * EOF * More terraform fix * Fixing format * Try terraform * Try diff terraform type
* get_delete_key_delegate_action moved to utils * get_add_key_delegate_action moved to utils * redundant get_add_key_delegate_action deleted * redundant get_key_info_with_helper deleted * TODOs, function renamed * sign_helper used in add key and delete key
Added two new templates as per standard process.
Updated tasklist in Epic, not formatted correctly.
* relayer url and api_key moved to the partner struct, refactoring * relayer set in tfvars * terraform parameter renamed * signing nodes accepts only oidc_providers
Added Epic Icon
* Rebase off of latest relayer * NUM_KEYS set to 1 --------- Co-authored-by: Serhii Volovyk <[email protected]>
* atomic account creation tests * register_account_atomic (broken) * Rebase off of latest relayer * NUM_KEYS set to 1 * atomic url fixed * return type in atomic acc creation fixed * atomic acc creation status error fxed --------- Co-authored-by: Phuong Nguyen <[email protected]>
* feat: terraform configuration (#170) * feat: add terraform module for partners (#294) * redundant variables deleted * terraform fmt * redundant parameters deleted * lookup_url deleted from setup * fmt * redundant dep deleted * duplicated service-account-datastore-user deleted * unused terraform value firebase_audience_id deleted * terraform fmt --------- Co-authored-by: Daniyar Itegulov <[email protected]> Co-authored-by: DavidM-D <[email protected]> Co-authored-by: Phuong Nguyen <[email protected]>
|
Godspeed resolving all the conflicts and make sure you don’t squash when you merge this! |
Terraform Dev EnvironmentTerraform Format and Style 🖌
|
ChaoticTempest
approved these changes
Sep 21, 2023
Terraform Feature Environment (dev-298)Terraform Initialization ⚙️
|
Terraform Feature Environment Destroy (dev-298)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.