feat: move away from ractor #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
approved these changes
Apr 5, 2023
| #[derive(Clone)] | ||
| struct SignNodeState { | ||
| id: NodeId, | ||
| sk_share: SecretKeyShare, |
There was a problem hiding this comment.
I think SignNodes should be aware of the LeadNode and accept requests only from it.
| @@ -0,0 +1,164 @@ | |||
| use crate::msg::{LeaderRequest, LeaderResponse, SigShareRequest, SigShareResponse}; | |||
There was a problem hiding this comment.
I feel like we will need to merge leader and sign nodes into one entity in the future. But yes, now this design looks resonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need actors and can just use plain HTTP instead for the sake of simplicity.
There are two CLI commands:
start-signthat starts a sign node with a single endpoint/signthat, given payload, checks it and signs it with its private key share.start-leaderthat start a leader node with a single endpoint/submitthat, given payload, distributes it across all sign nodes and, once it has enough responses, assembles it into a full signature.