-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more intuitive portable-atomic feature etc. #172
more intuitive portable-atomic feature etc. #172
Conversation
Any chance you could bump the MSRV too? You can find it in |
fe7f192
to
a255f07
Compare
a255f07
to
bc95aa5
Compare
I have now rebased this PR on PR #171, updated some documentation to avoid duplicated info, updated MSRV in both Cargo.toml & Please let me know if anything else is needed from me, my apologies for the delay. /cc @jamesmunns @Dirbaio |
Authored-by: James Munns <[email protected]> Co-authored-by: @brody4hire - C. Jonathan Brody <[email protected]>
Authored-by: James Munns <[email protected]>
bc95aa5
to
aed6a8e
Compare
Now updated again, as discussed, tested in my personal fork: brody4hire#1 Please let me know if anything else is needed from me. |
Thanks, will try to get some time to review this in full this week! |
I couldn't find any issues, thanks for the PR! Do you need this in a public release soon, or are you happy to hold on until the next one? |
I should be able to work around this, but a public release could be quite a bit helpful. I am preparing to announce a fork of rustls for extry-tiny embedded systems, and would likely want to include a fork of rustls-rustcrypto provider that uses I found the requirement to use underscore for the portable-atomic feature to avoid build issues to be really confusing, one more thing to document to avoid tripping up any possible downstream users. Thanks for taking the time to review & merge these updates 🎉 |
Fixes #170 - non-breaking feature update - based on & supersedes PR #171
UPDATED as follows
dep:
syntax updates from PR Usedep:
syntax for portable-atomic #171.github/
I have also tried CI in my own fork: brody4hire#1
P.S. I was hoping that the implicit feature support would be removed in Rust 2024, which is part of the root cause, but this update is now held up: rust-lang/cargo#12826 (comment)
/cc @jamesmunns @Dirbaio