docs: examples pages + upgrade Astro #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 78.63% 78.63%
=======================================
Files 58 58
Lines 10782 10782
=======================================
Hits 8478 8478
Misses 2304 2304 ☔ View full report in Codecov by Sentry. |
2 tasks
luwes
changed the title
luwes
changed the title
luwes
changed the title
by downgrading.
luwes
added a commit
that referenced
this pull request
Feb 1, 2024
This change adds a docs examples page with Sandpack. The examples are pulled from the examples/vanilla folder. This is just a start, would like to add more and more examples. The HTML is editable and for the themes one can also edit the theme in place and open it up in Sandbox for keeping their own copy for example. The goal is to show off more with the cool things that can be easily build with media-chrome and to be easier discoverable. https://media-chrome-docs-git-fork-luwes-docs-upgrade-mux.vercel.app/docs/en/examples --- Upgrades the docs dependencies and Astro to v4. Vite has a regression which is reported here vitejs/vite#15702 which Astro runs into together with the React Sandpack library. So I pinned it to vite 5.0.10 to get around that. Sandpack has a regression which I submitted an issue for here: codesandbox/sandpack#1068 The rest seemed to work, a few more warnings in the CLI when building.
luwes
added a commit
that referenced
this pull request
Feb 1, 2024
This change adds a docs examples page with Sandpack. The examples are pulled from the examples/vanilla folder. This is just a start, would like to add more and more examples. The HTML is editable and for the themes one can also edit the theme in place and open it up in Sandbox for keeping their own copy for example. The goal is to show off more with the cool things that can be easily build with media-chrome and to be easier discoverable. https://media-chrome-docs-git-fork-luwes-docs-upgrade-mux.vercel.app/docs/en/examples --- Upgrades the docs dependencies and Astro to v4. Vite has a regression which is reported here vitejs/vite#15702 which Astro runs into together with the React Sandpack library. So I pinned it to vite 5.0.10 to get around that. Sandpack has a regression which I submitted an issue for here: codesandbox/sandpack#1068 The rest seemed to work, a few more warnings in the CLI when building.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a docs examples page with Sandpack.
The examples are pulled from the examples/vanilla folder.
This is just a start, would like to add more and more examples.
The HTML is editable and for the themes one can also edit the theme in place and open it up in Sandbox for keeping their own copy for example.
The goal is to show off more with the cool things that can be easily build with media-chrome and to be easier discoverable.
https://media-chrome-docs-git-fork-luwes-docs-upgrade-mux.vercel.app/docs/en/examples
Upgrades the docs dependencies and Astro to v4.
Vite has a regression which is reported here vitejs/vite#15702 which Astro runs into together with the React Sandpack library. So I pinned it to vite 5.0.10 to get around that.
Sandpack has a regression which I submitted an issue for here:
codesandbox/sandpack#1068
The rest seemed to work, a few more warnings in the CLI when building.