[code-infra] Rename CI checks to be more human readable #16910
+32
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JCQuintas
commented
Mar 11, 2025
JCQuintas
commented
- I have followed (at least) the PR section of the contributing guide.
JCQuintas
added
enhancement
|
Deploy preview: https://deploy-preview-16910--material-ui-x.netlify.app/ |
JCQuintas
changed the title
JCQuintas
changed the title
|
It seems we would need to update the required steps in GitHub. |
Comment on lines
347
to
+349
| - test_unit: | ||
| <<: *default-context | ||
| name: 'JSDOM tests' |
There was a problem hiding this comment.
This was nice before to train us to know that pnpm test:unit runs this one.
There was a problem hiding this comment.
We would usually check the circleci log to see why it failed, and the step will tell you the exact command to run. Both our browser and jsdom tests are unit tests, so it is a bit misleading.
For context, this is based on the base-ui changes, which we agreed on code-infra to bring to other repos: mui/base-ui#1321
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Jose C Quintas Jr <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Jose C Quintas Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.