Added the functionality of using a TextView instead of a ImageView #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-progressbar Conflicts: android-square-progressbar-example/.classpath android-square-progressbar-example/AndroidManifest.xml android-square-progressbar-example/project.properties android-square-progressbar/.classpath android-square-progressbar/project.properties android-square-progressbar/src/net/yscs/android/square_progressbar/SquareProgressBar.java
|
Hey Anshul (@AnshulBansal) Thank you very much for your pull request. I like the idea very much and thanks for your effort. I think I can optimize the code a bit and add some more settings that can be set on the SquareProgressBarWithText. I will do them basing on your pull request on a separate branch, so you then can review the changes before I merge them into the head branch. Is this okay from your side? Cheers |
|
Hey Yannick, It is completely fine from my side and also thank you for this great library. It is helping me a lot in the android game i am developing. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement it in your code just use SquareProgressBarWithtext instead of SquareProgressBar
Example Call
<net.yscs.android.square_progressbar.SquareProgressBarWithText
android:id="@+id/subi"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_alignParentTop="true"
android:layout_centerHorizontal="true"
android:paddingTop="20dp" >
</net.yscs.android.square_progressbar.SquareProgressBarWithText>
squareProgressBar = (SquareProgressBarWithText) findViewById(R.id.subi);
squareProgressBar.setText("GDG");
squareProgressBar.setHoloColor(color.holo_blue_dark);
squareProgressBar.setProgress(0);
squareProgressBar.setWidth(8);
squareProgressBar.setOpacity(false);