Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Fix bug where notifications can disappear/lose association with task #1188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

camgraff
Copy link
Contributor

Since adding the ability to pin tasks as notifications in #1170 I've found a couple issues with the current implementation. Namely:

  • Sometimes pinned notifications will randomly disappear. It seems like this was caused by the app being restarted by the OS/crashing in the background as I could reproduce in an emulator by running adb shell am force-stop nl.mpcjanssen.simpletask.debug.

Solution: Create the notifications from a Service and call startForeground.

  • If the todo list is modified outside of simpletask, the task IDs will change causing the notifications to lose their association with each task.

Solution: Make the task IDs persistent by storing them in SharedPreferences.

@mpcjanssen
Copy link
Owner

@camgraff, thank you for this PR. It does seem to have quite a few moving parts so I would like to review it or at least understand it in a bit more detail. Unfortunately I do not have time for that right now so it's going to take some time for this to be merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants