Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo and missed async keyword #3177

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: typo and missed async keyword #3177

merged 1 commit into from
Jun 21, 2024

Conversation

Decodetalkers
Copy link
Contributor

I am reading the repo to learn something, but typos-lsp told me that there are some typos. So I think maybe I can make a pr.. and lsp said that there are some async keywords are missing.

@Rob--W
Copy link
Member

Rob--W commented Jun 21, 2024

async is not strictly necessary if a Promise is already returned, but adding it does not hurt either.

@Rob--W Rob--W merged commit b50b2f4 into mozilla:master Jun 21, 2024
4 checks passed
@Decodetalkers Decodetalkers deleted the typo branch June 21, 2024 14:51
aklinker1 pushed a commit to aklinker1/web-ext that referenced this pull request Jul 20, 2024
@Decodetalkers @aklinker1
chore: typo and missed async keyword (mozilla#3177)
ef49660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Decodetalkers @Rob--W