Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed npm dependency from require-uncached to import-fresh #1691

Merged
merged 2 commits into from
Sep 26, 2019
Merged

fix: Changed npm dependency from require-uncached to import-fresh #1691

merged 2 commits into from
Sep 26, 2019

Conversation

sibiraj-s
Copy link
Contributor

require-uncached is renamed to import-fresh.

@sibiraj-s sibiraj-s changed the title Use import-fresh instead of require-uncached chore: use import-fresh instead of require-uncached Sep 1, 2019
@coveralls
Copy link

coveralls commented Sep 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d9aac3c on sibiraj-s:update-import-fresh into 052a914 on mozilla:master.

@ghost
Copy link

ghost commented Sep 12, 2019

Fixes #1703

@Rob--W Rob--W requested a review from rpl September 13, 2019 11:26
@rpl rpl changed the title chore: use import-fresh instead of require-uncached fix: Changed npm dependency from require-uncached to import-fresh Sep 26, 2019
@rpl rpl merged commit 0d7e491 into mozilla:master Sep 26, 2019
@rpl
Copy link
Member

rpl commented Sep 26, 2019

I've just approved and merged this PR. Thanks @sibiraj-s!

@sibiraj-s sibiraj-s deleted the update-import-fresh branch September 26, 2019 11:22
@caitmuenster
Copy link

Thanks so much for the patch, @sibiraj-s! Your contribution has been added to our recognition wiki.

Would you be interested in creating an account on mozillians.org? I'd be happy to vouch for you.

@sibiraj-s
Copy link
Contributor Author

@caitmuenster Sure. thanks. here is my profile https://mozillians.org/en-US/u/sibiraj-s/

@caitmuenster
Copy link

Awesome! Your profile is vouched. ✨

Welcome onboard! I look forward to seeing you around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants