Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot consistently start chromium on macOS #1779

Closed
jezhou opened this issue Dec 10, 2019 · 2 comments · Fixed by #1796
Closed

Cannot consistently start chromium on macOS #1779

jezhou opened this issue Dec 10, 2019 · 2 comments · Fixed by #1796

Comments

@jezhou
Copy link
Contributor

jezhou commented Dec 10, 2019

Is this a feature request or a bug?

Bug

What is the current behavior?

When I run web-ext run --target chromium, it doesn't seem to correctly start the Websocket server, which prevents Chrome + the extension from launching. This also happens when I run npm test in the web-ext project.

Running web-ext test suite
70387504-92457d00-195a-11ea-9e95-d1e2a9a0db91

Running web-ext cli with chromium
70387568-6080e600-195b-11ea-8410-52b25567be96

Curiously, this will sometimes work if I use node v13.2.

image

I have Chrome installed on my computer. Am I missing a step in the setup?

What is the expected or desired behavior?

Websocket server is successfully started, and Chrome + the extension launches consistently.

Version information (for bug reports)

macOS
10.14.6

Chrome
78.0.3904.108

node --version && npm --version && npx web-ext --version
v10.15.1, v13.2.0
6.11.3
3.2.1

@Rob--W
Copy link
Member

Rob--W commented Dec 10, 2019

wss is set at the start of setupInstance, at

this.wss = new WebSocket.Server({

The error is "Cannot read property 'address' of null", which implies that wss has become null. This only happens when exit() is called -

this.wss = null;

If this error occurs, then exit() has most likely been called, unexpectedly.

@rpl
Copy link
Member

rpl commented Dec 10, 2019

Interestingly it seems that we are triggering the same failure in the windows travis worker on an unrelated pull request (#1780): https://travis-ci.org/mozilla/web-ext/jobs/623117080#L682-L688

@rpl rpl closed this as completed in #1796 Dec 19, 2019
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Dec 19, 2020
The AUR package was maintained by myself and was called web-ext. Using the name to conform to the new Node.js packaging guidelines [1].

Also restoring Chromium tests - seems the issue has been fixed since version 4.0 [2].

[1] https://wiki.archlinux.org/index.php?title=Node.js_package_guidelines&type=revision&diff=599637&oldid=582142
[2] mozilla/web-ext#1779



git-svn-id: file:///srv/repos/svn-community/svn@779976 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Dec 19, 2020
The AUR package was maintained by myself and was called web-ext. Using the name to conform to the new Node.js packaging guidelines [1].

Also restoring Chromium tests - seems the issue has been fixed since version 4.0 [2].

[1] https://wiki.archlinux.org/index.php?title=Node.js_package_guidelines&type=revision&diff=599637&oldid=582142
[2] mozilla/web-ext#1779



git-svn-id: file:///srv/repos/svn-community/svn@779976 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants