Import Firefox 71b4 schema #2892
Conversation
EnTeQuAk
force-pushed
the
2891-schema-firefox71
branch
from
86efe08 to
165286f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2892 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 58 58
Lines 1919 1919
Branches 404 404
=======================================
Hits 1917 1917
Misses 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks good.
In particular, we are still going to show linting warning for proxy.register/unregister and proxy.onProxyError, because (even if they are not in the schema anymore) they are still part of the DEPRECATED_JAVASCRIPT_APIS mapping table.
But I just noticed that in #2747 we missed to add proxy.registerProxyScript in the mapping table, which was also deprecated and it has been removed in this schema import. Would you mind to add it in this pull request or in a separate one?
(As a side note: in the future schema imports we should always double-check that we are adding to that table the APIs we are completely removing, otherwise they are detected as UNSUPPORTED_APIS and the resulting linting message is going to say "This API has not been implemented by Firefox." :-P, or maybe we should try to make use of the mdn-browser-compat-data for the the deprecation warnings of APIs not available in the API schema anymore, as it may "scale better" than the mapping table).
(As a side - side note... I also noticed that on the Firefox side we missed to remove onProxyError from the schema in Bug 1443259, sigh, but don't worry about that I'll deal with it).
Fixes #2891