Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Detect unsupported images used in static themes manifest #2271

Conversation

rpl
Copy link
Member

@rpl rpl commented Nov 8, 2018

Fixes #2051

This PR adds the following 5 new validations rules (also added to the docs/rules.md file in this PR):

  • errors:

    • MANIFEST_THEME_IMAGE_NOT_FOUND (Theme images missing)
    • MANIFEST_THEME_IMAGE_CORRUPTED (The linter is unable to read their mime types)
    • MANIFEST_THEME_IMAGE_WRONG_EXT (Theme images must have one of the supported file extensions)
    • MANIFEST_THEME_IMAGE_WRONG_MIME (Theme images mime type must be a supported format)
  • warnings:

    • MANIFEST_THEME_IMAGE_MIME_MISMATCH (the format is supported, as well as the file extension, but the mime doesn't match the file extension the linter expects)

TODO list

@rpl rpl closed this Nov 8, 2018
@rpl rpl reopened this Nov 8, 2018
@rpl rpl closed this Nov 8, 2018
@rpl rpl reopened this Nov 8, 2018
@rpl rpl force-pushed the fix/issue-2051-unsupported-image-format-in-static-themes branch from c18adc8 to b465922 Compare November 8, 2018 18:39
@rpl rpl requested a review from mstriemer November 8, 2018 19:08
Copy link
Contributor

@mstriemer mstriemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, lots of test cases.

A few comments, but nothing that would change the structure of this much.

@rpl rpl force-pushed the fix/issue-2051-unsupported-image-format-in-static-themes branch from b465922 to 4ecd9bc Compare November 12, 2018 15:59
@rpl rpl force-pushed the fix/issue-2051-unsupported-image-format-in-static-themes branch from 4ecd9bc to 18d82be Compare November 12, 2018 17:59
@rpl rpl merged commit 3bf8309 into mozilla:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants