-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Detect unsupported images used in static themes manifest #2271
Merged
rpl
merged 2 commits into
mozilla:master
from
rpl:fix/issue-2051-unsupported-image-format-in-static-themes
Nov 12, 2018
Merged
fix: Detect unsupported images used in static themes manifest #2271
rpl
merged 2 commits into
mozilla:master
from
rpl:fix/issue-2051-unsupported-image-format-in-static-themes
Nov 12, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c18adc8
to
b465922
Compare
mstriemer
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, lots of test cases.
A few comments, but nothing that would change the structure of this much.
b465922
to
4ecd9bc
Compare
4ecd9bc
to
18d82be
Compare
This was referenced Nov 14, 2018
This was referenced Dec 31, 2018
This was referenced Mar 1, 2019
This was referenced Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2051
This PR adds the following 5 new validations rules (also added to the docs/rules.md file in this PR):
errors:
warnings:
TODO list
double-check the additional tests are enough to bring back the code coverage to the current statuswhy coveralls is not in the list of the checks? :-(