Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning integration #991

Draft
wants to merge 105 commits into
base: master
Choose a base branch
from
Draft

Lightning integration #991

wants to merge 105 commits into from

Conversation

szmazurek
Copy link
Collaborator

Fixes #

Proposed Changes

  • moving gandlf logic to Lightning framework

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

szmazurek and others added 30 commits December 6, 2024 09:35
- basic primitves for lightning port
- added calculation of overall metrics
- added proper handling of data formats for both progress bar logging
  and gandlf custom logging
- added tests for regression and classification
- little refactoring of tests
Forward pass lightning - training pipeline
@szmazurek szmazurek requested a review from a team as a code owner March 7, 2025 10:37
Copy link
Contributor

github-actions bot commented Mar 7, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 50.57895% with 939 lines in your changes missing coverage. Please review.

Project coverage is 35.97%. Comparing base (ed38f96) to head (e9b47cc).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
testing/test_lightning_components.py 23.02% 361 Missing ⚠️
GANDLF/models/lightning_module.py 65.91% 289 Missing ⚠️
GANDLF/utils/imaging.py 22.53% 55 Missing ⚠️
...DLF/privacy/opacus/opacus_anonymization_manager.py 33.33% 54 Missing ⚠️
testing/test_full.py 10.41% 43 Missing ⚠️
GANDLF/inference_manager.py 14.81% 23 Missing ⚠️
GANDLF/metrics/metric_calculators.py 67.14% 23 Missing ⚠️
GANDLF/training_manager.py 58.92% 23 Missing ⚠️
GANDLF/losses/loss_calculators.py 57.69% 22 Missing ⚠️
GANDLF/data/lightning_datamodule.py 74.07% 14 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #991       +/-   ##
===========================================
- Coverage   92.01%   35.97%   -56.05%     
===========================================
  Files         171      178        +7     
  Lines       10035    11843     +1808     
===========================================
- Hits         9234     4260     -4974     
- Misses        801     7583     +6782     
Flag Coverage Δ
unittests 35.97% <50.57%> (-56.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarthakpati sarthakpati marked this pull request as draft March 7, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants