Updates to video_capture program #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path to the directory is accepted as the first command line argument of the program. The program checks whether the directory exists and if not creates it.
Each frame is given a sequence number starting from 1. To make testing easy, reduced the frame rate.
Time stamps are in UTC. Format: sequence#_yyyy-mm-dd_hh-mm-ss.milsec.png
Appended the number of milliseconds between each frame and the previous frame (gap) to the end of the file name. Format: sequence#_yyyy-mm-dd_hh-mm-ss.milsec~gap.png One problem I see is that the gaps are not uniform. I am not sure how to fix this.
The amount of time taken to capture a frame is computed and it is subtracted from the frame period to adjust the time to wait till the start of capturing the next frame. Quick tests show that the variability is mostly kept below 10 milliseconds.
Studied the date.h header and figured out how to directly format the date and time avoiding latter string replacement operations.
However, in my testing, I felt that it is not working as expected.
…w to find opencv4. Made small improvements in the code to avoid crashing.
…specific instructions
paulosaurusrex
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
It all looks great. @adarshp can we hold this for a while before merging until I get the uber script updated for tomorrow?
|
@paulosoaresua - sure thing, we can hold off for now and you can merge it whenever you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following updates to the video_capture program.
--out_dirargument can now have tildes (thanks @manujinda !)--helpoption to actually work properly (it was throwing an exception earlier).