Various Community PRs #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… could have been modified between evaluating statement and executing block
Access the timedEvents property inside of a readWriteLock.
Check flush interval > 0 inside the dispatch block
Setting explicit autorelease frequency
Fixes - - Made concurrentQueue private as it is not used anywhere else outside this file - Fixed spelling mistake - removed unnecessary self
|
Nice list of fixes/improvements :) It got me thinking though about a future overhaul to completely replace DispatchQueue/locks with Swift concurrency Tasks/async-await/actors Seems like it would eliminate a lot of footguns with DispatchQueue.sync etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the changes from the following PRs with the necessary config changes needed to run CI tests against them...
#576 - thanks @vikas171999
#579 - thanks @adamwulf
#583 - thanks @julsh
#588 - thanks @prydain007