Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disk I/O error caused by race condition from multiple initializations with the same token #519

Merged
merged 6 commits into from
Feb 19, 2022

Conversation

zihejia
Copy link
Contributor

@zihejia zihejia commented Feb 19, 2022

addresses #512

@zihejia zihejia added the bug label Feb 19, 2022
zihejia and others added 2 commits February 18, 2022 17:04
Co-authored-by: Jared McFarland <[email protected]>
Copy link
Contributor

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zihejia zihejia merged commit 21147f5 into master Feb 19, 2022
@gabriellanata
Copy link
Contributor

gabriellanata commented Mar 4, 2022

This PR broke initializing mixpanel on Mac. Specifically making the Mac initializer also use the DispatchSemaphore causes a deadlock. Reported as issue #524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants