Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix macos build issues #799

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

🐛 Fix macos build issues #799

wants to merge 2 commits into from

Conversation

yhs0602
Copy link

@yhs0602 yhs0602 commented Jan 20, 2025

This pull request handles

@Miffyli
Copy link
Contributor

Miffyli commented Jan 21, 2025

Heya! Thanks for the PR. Generally looks good, just need to ensure the installation works right still on Windows and Linux as well.

Should this now work out of the box on M1/2/3 Macs as well, just with requirements installed?

@yhs0602
Copy link
Author

yhs0602 commented Jan 31, 2025

On my M1 Pro, this works fine: (mamba is just a more efficient version of conda)

mamba create --name install_minerl python=3.11  
mamba activate install_minerl
mamba install conda-forge::openjdk=8
pip install git+https://github.com/yhs0602/minerl

On Linux, this works fine as well:

conda create -n install_minerl python=3.11
conda activate install_minerl
conda install conda-forge::openjdk=8
pip install git+https://github.com/yhs0602/minerl

🎉

However, on Windows, this does not work... Maybe I need to use WSL?

conda create -n install_minerl python=3.11
conda activate install_minerl
conda install conda-forge::openjdk=8
pip install git+https://github.com/yhs0602/minerl

I had to fix WSL Bash (Docker Desktop) following solution: microsoft/WSL#5923 (comment)

wsl -s Ubuntu

I couldn't get pip to use Git Bash along with Conda and JDK--it kept trying to use WSL's Bash. As a result, I had to install openjdk-8-jdk on my WSL.

And after that finally installing minerl on windows also succeeded 🎉

@yhs0602
Copy link
Author

yhs0602 commented Mar 10, 2025

Hello, is there a plan to merge this PR, so that other MacOS users to install MineRL easily on their devices? @Miffyli

@yhs0602
Copy link
Author

yhs0602 commented Mar 12, 2025

Nevermind - I think we have to apply this comment's step 5 also:

#659 (comment)

@Miffyli
Copy link
Contributor

Miffyli commented Mar 12, 2025

Hey! Sorry for dropping the ball on this (feel free to nudge me). Is adding the extra step something you'd like to add to the PR so I can test it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants