Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[references] Recognition - Allow built-in datasets usage #1904

Merged
merged 9 commits into from
Mar 26, 2025

Conversation

sarjil77
Copy link
Contributor

hey @felixdittrich92,

now we are able to use the builtin dataset, and it is working fine.

@sarjil77
Copy link
Contributor Author

sarjil77 commented Mar 22, 2025

@felixdittrich92, here i am able to use the builtin dataset but also facing one issue:

getting this type of error in some of the dataset, it is workign fine for the SVNH but for others which have space between words are facing this kind of issue.

ValueError: some characters cannot be found in 'vocab'.                          Please check the input string ACUTE CADCOVASCULAR and the vocabulary 0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~°£€¥¢฿àâéèêëîïôùûüçÀÂÉÈÊËÎÏÔÙÛÜÇ

and the error is because of input_string: ACUTE CADCOVASCULAR, so space between them causes the error and when i tried to add the space in the vocab.

i got error like regarding:
the vocabulary size in your model does not match the pre-trained checkpoint.

please have a look on this. :)

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (18b8db9) to head (f4e9d0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
- Coverage   96.65%   96.55%   -0.11%     
==========================================
  Files         166      166              
  Lines        7991     8000       +9     
==========================================
  Hits         7724     7724              
- Misses        267      276       +9     
Flag Coverage Δ
unittests 96.55% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixdittrich92
Copy link
Contributor

@felixdittrich92, here i am able to use the builtin dataset but also facing one issue:

getting this type of error in some of the dataset, it is workign fine for the SVNH but for others which have space between words are facing this kind of issue.

ValueError: some characters cannot be found in 'vocab'.                          Please check the input string ACUTE CADCOVASCULAR and the vocabulary 0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~°£€¥¢฿àâéèêëîïôùûüçÀÂÉÈÊËÎÏÔÙÛÜÇ

and the error is because of input_string: ACUTE CADCOVASCULAR, so space between them causes the error and when i tried to add the space in the vocab.

i got error like regarding: the vocabulary size in your model does not match the pre-trained checkpoint.

please have a look on this. :)

Thanks I will have a look on monday 👍🏼
I think we should filter the possible choices here because some datasets like SROIE contains partial word group annotations (including whitespaces) instead of single word annotations.

@sarjil77
Copy link
Contributor Author

yes, that sounds good,
and the issue is only becuase of partial word group annotations (including whitespaces).

OR we can include the whitespace in the vocab.

let me know for other further changes required here.

@felixdittrich92
Copy link
Contributor

As discussed some updates required :)

@felixdittrich92 felixdittrich92 self-assigned this Mar 26, 2025
@felixdittrich92 felixdittrich92 added this to the 0.12.0 milestone Mar 26, 2025
@felixdittrich92 felixdittrich92 added module: datasets Related to doctr.datasets ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text recognition Related to the task of text recognition type: new feature New feature labels Mar 26, 2025
@felixdittrich92
Copy link
Contributor

Related to: #1830

@felixdittrich92 felixdittrich92 changed the title fixed the #1830 able to use builtin datsset [references] Recognition - Allow built-in datasets usage Mar 26, 2025
@sarjil77 sarjil77 force-pushed the feature/add-svnh-support branch from 8e4b385 to 5d4e489 Compare March 26, 2025 11:49
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing 👍

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗 Looks good now 👍

@felixdittrich92 felixdittrich92 merged commit fffcccc into mindee:main Mar 26, 2025
67 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: datasets Related to doctr.datasets topic: text recognition Related to the task of text recognition type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants