-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[references] Recognition - Allow built-in datasets usage #1904
[references] Recognition - Allow built-in datasets usage #1904
Conversation
@felixdittrich92, here i am able to use the builtin dataset but also facing one issue: getting this type of error in some of the dataset, it is workign fine for the SVNH but for others which have space between words are facing this kind of issue.
and the error is because of input_string: ACUTE CADCOVASCULAR, so space between them causes the error and when i tried to add the space in the vocab. i got error like regarding: please have a look on this. :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1904 +/- ##
==========================================
- Coverage 96.65% 96.55% -0.11%
==========================================
Files 166 166
Lines 7991 8000 +9
==========================================
Hits 7724 7724
- Misses 267 276 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks I will have a look on monday 👍🏼 |
yes, that sounds good, OR we can include the whitespace in the vocab. let me know for other further changes required here. |
As discussed some updates required :) |
Related to: #1830 |
8e4b385
to
5d4e489
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🤗 Looks good now 👍
hey @felixdittrich92,
now we are able to use the builtin dataset, and it is working fine.