Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce experimental support for CUSTOM PLACEHOLDERS #837

Merged
merged 4 commits into from
Jul 29, 2022

Conversation

mikepenz
Copy link
Owner

@mikepenz mikepenz commented Jul 29, 2022

  • introduce ES2021.String for replaceAll
  • expand Configuration with custom_placeholders configuration
    • custom placeholders allow to extract values of placeholders and then use these in templates
  • refactor replacing PR template values
  • introduce capability for custom placeholders also to the global template
  • introduce new convenient functions to handle this
  • expand custom placeholders to the global template
  • introuce capability of accessing and referencing custom placeholders of PRs in the global template
${{CUSTOM_PLACEHOLDER[0]}}
${{CUSTOM_PLACEHOLDER[*]}}
  • introduce new testcase checking the custom placeholder functionality
  • add logic which cleans up custom placeholders with the [] syntax which were not matched

See the testcase on how to use it:
https://github.com/mikepenz/release-changelog-builder-action/pull/837/files#diff-7bed9bc5c1116651b2cb14555fa0b7af85c8e4c1f42e0923bbc62a308a4d4375R588-R625

mikepenz added 4 commits July 29, 2022 14:29
- expand Configuration with `custom_placeholders` configuration
  - custom placeholders allow to extract values of placeholders and then use these in templates
- refactor replacing PR template values
…plate

- introduce new convenient functions to handle this
- introuce capability of accessing and referencing custom placeholders of PRs in the global template
```
${{CUSTOM_PLACEHOLDER[0]}}
${{CUSTOM_PLACEHOLDER[*]}}
```
- introduce new testcase checking the custom placeholder functionality
@mikepenz mikepenz merged commit f0807d2 into develop Jul 29, 2022
@mikepenz mikepenz deleted the feature/custom_placeholders branch February 15, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant