-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating from string resources to SPI #503
Comments
If we can make it work for android without any major overhead I would say absolutely. |
We can make this, but we need to switch to jar packaging for typeface libraries. And obfuscation work perfectly with SPI :) |
Why would we need the jar packaging? the aar packaging is like a jar with additional features. |
Aar removes META-INF folder from package, but SPI requires it |
hmmmm then there may be a different issue, as this may get lost in the end again via proguard. many people have a packaging rule to exclude meta inf files. due to conflicts of other libs.. :/ |
Hmm, ok, I’ll investigate this |
My bad, it works perfectly with aar and auto-service (which adds all required information in META-INF automatically) |
Hmm I would propose that we have a look on how this meta data has to look like and we add it manually then to not rely on external dependencies. |
I'we tried to add |
but it will have to be mentioned in the licenses. and as it is a compile time dependency only, there is no reference left in the dependency tree, so AboutLibraries won't see it :D Oh the META-INF won't be in the res folder. as it is "special" compile time. I think we may be able to write to it via gradle :) |
Sounds good :) |
Theoretically we could just use the ContentProvider of android to auto register the font dependencies... I am not really sure about the real world performance impact of having many contentProviders in an app :/ so let's say there are 5 fonts in an app. what would be the impact? |
Idk, we need to test it |
Well google just made this one a lot easier :D https://developer.android.com/topic/libraries/app-startup |
Look's so pretty and easy. We'll wait for stable version? |
I'd say we prepare a beta release of Android-Iconics v6 :D and wait for it's release until the app startup library is at least in beta :) I'm gonna spend a bit of time on this, this week to prepare things :) |
What do you think about migrating to Java Service Provider Interface?
The text was updated successfully, but these errors were encountered: