-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iconics 3.2.5 crash on Android 10 #470
Comments
@simone-gasparini what is the issue you have with v4? I guess also v4 would still face the same problem. What you can do as a quick solution. Don't use the inflator and use the specific |
@mikepenz with v4 and Java i continue to get the error: With
and even with
|
Investigating the issue i've found that the error is related to the attachBaseContext wrapper. At the moment I've forked and fixed v3: |
For the issue you face with v4. You can either init with your context in your application or the first place before using
or you enable the content provider specifying this in your res:
|
Android-Iconics/library-core/src/main/java/com/mikepenz/iconics/context/InternalLayoutInflater.kt Line 159 in db57dc0
|
@simone-gasparini I know it is not the optimal solution but the quickest. Use the IconicsImageView and remove the custom inflater. Will look into implementing the thing you posted above for caligraphy |
At the moment these are already IconicsImageView
|
it is strange as those problems seem to not occur in the sample. unless I totally overlooked it |
Yes, the initial problem occur even in your sample at v3.2.5 tag in the OldAutomaticActivity, but with v4 it's ok. Better inspecting log I've noticed these lines Without any Iconics class instantiated:
With IconicsImageView in xml
Can this be related to the issue? |
I am gonna deprecate the inflator and the context wrapper because of this. Please use the specific views moving forward. Also I highly recommend to update to v4 :) |
…n favor of the IconicsImageView and IconicsTextView * Also related to: #470
v3.x as it is an old release will not be updated anymore. I highly recommend either to use the views directly due to the Android Q problem or to use your fixed branch :) |
It works like a charm! There is only to fix the README because reference the step 3 |
done @simone-gasparini . thanks :) |
Hi @simone-gasparini @mikepenz, Thanks for discussing the issue but, sorry, I am still a bit unclear as to what is the exact fix. Using Kotlin is out of question for us right now due to limited resources. Initialization of Iconics libraryHave a very basic usage. Am only using Below is the only code snippet in the MyFirstActivityClass (class that is crashing on Android 10) :-
Error thrown is
Two Usages of Iconics for inserting iconsBelow is the text from strings.xml that is programmatically assigned to a text view of a dialog box that is shown by the first activity (MyFirstActivityClass that is crashing on Android 10) :-
Below is a code snippet on how iconics is used later in other classes :-
As you can see the usage is very basic. Would really appreciate your help or feedback on how to resolve this. Thanks in advance. |
@prateekarora as you can see in the latest README and latest releases. We have deprecated the Also there are better alternatives available in this library. E.g. using an So I highly recommend you to turn away from the |
Just wanting to mention as this has already caused a lot of confusion without a warrant across many libraries, but you don't need to use Kotlin for using a Kotlin first library. Kotlin is fully compatible with Java, that is its main selling point. You can call and use any kotlin JVM library in Java without any issue. If you are worries of lack of resources in context of people not wanting to/accustomed to work with Kotlin, then you can just imagine a Kotlin library being written in Java, and call it like that, and there won't be any change in behavior. Kotlin is not a separate runtime, it is compiled to the same JVM bytecode as any Java library. If you are using libraries like OkHTTP 4, then you are already using a Kotlin library |
* Intermediate Iconics upgrade * Switch to implementation, and very latest iconics * WIP: bumping Mike Penz requires us to have switched to Android X already * Various iconics-related upgrades * Resolve some compile warnings * Comment tweaks * Move away from deprecated usage of IconicsContextWrapper (see mikepenz/Android-Iconics#470) * Make use of some more Material icons; simplify the IconicsHelper * Change the signatures of IconicsHelper functions, to simplify usage * Make use of some more Material icons - and remove some old PNGs * Rework a couple of classes into Kotlin... allowing us to bin another old icon * Move three more icons to being provided by the icon library * Update to new navigation icons * Remove some more unused icons * Scaled copies of the compass icons * Rename wisps icons to prefix with wp for clarity and grouping * Rearrange unused assets for clarity * Initialise screenlock button correctly * Move out unused assets * Remove unused rendertheme now provided (presumably) by MapsForge library itself * Use Material icon intsead of blurry PNG for 'route now' button * Update Cyclestreets logo used at the start of LiveRide, to make it less blurry * Update What's New etc * Make POI icons clearer * Fix bug in initialisation of POI category ListView, so it can be reused without going mental * Add icons to the root of the Settings page
hello mike, i m not experienced developer but i found error when i migrate android 28 to 29 and the error is like this, can you please help me to fix this, /CustomActivityOnCrash: The previous app process crashed. This is the stack trace of the crash: |
@NatyN-teac the Please update to the latest release of the library which no longer offers that feature |
thanks for your response, can you please check my configuration, here it is: ---------------------------------------------////////////////////////----------------------------------------------- and the error keeps coming even after i update the iconics-core to latest i m using java for Android and i have migrated to AndroidX and the error is like this: Binary XML file line #17 in ru.livepic.java:layout/abc_screen_simple: Binary XML file line #17 in ru.livepic.java:layout/abc_screen_simple: Error inflating class androidx.appcompat.widget.FitWindowsLinearLayout can you please refer my configuration and suggests solution, im stuck the whole days trying to fix this |
@NatyN-teac I am sorry but this outlined issue does not look to be related to this library this states you have some screen which uses a layout which won't exist with the androidX libraries.
|
About this issue
Details
Checklist
Stacktrace
The text was updated successfully, but these errors were encountered: