Black icons with alpha remain black

[rubengees]

About this issue

After upgrading from 3.1.0 to 3.2.2, black icons with alpha remain completly black.
I reproduced this in the sample (On Android 9.0), when changing this line:

Android-Iconics/app/src/main/java/com/mikepenz/iconics/sample/item/IconItem.java

Line 52 in 29e1374

holder.image.getIcon().color(Color.BLACK);

to:

holder.image.getIcon().color(Color.parseColor("#77000000"));

3.1.0	3.2.2

I also quickly checked the latest alpha and were able to produce similar results.

Details

• Used library version: 3.2.2
• Used support library version: appcompat 1.0.2
• Used gradle build tools version: 3.3.2
• Used tooling / Android Studio version: 3.5 Canary 7

Checklist

• Searched for similar issues
• Checked out the sample application
• Read the README
• Checked out the CHANGELOG
• Read the FAQ
• Checked out the MIGRATION GUIDE

[zTrap]

Fixed in #443

[marbat87]

Could you fix this in 4.0.0-b1 version also?

Thanks in advance

[mikepenz]

Fixed in v3.2.3

@marbat87 we will fix this in an upcoming update to the v4.x version too. Please report on the v4 PR as a reminder

[rubengees]

@zTrap @mikepenz I tried the latest version, but am still able to reproduce that in some places in my app.

One place in the sample (current develop branch) is the drawer:

In previous versions (like 3.1.0) the icons were gray by default. Now they are black. Setting withIconColor(Color.parseColor("#77000000")) for example here:

Android-Iconics/app/src/main/java/com/mikepenz/iconics/sample/MainActivity.java

Line 89 in 959a567

PrimaryDrawerItem pdi = new PrimaryDrawerItem()

has no effect.

Another place is when setting a compound drawable on any TextView:

final Drawable compoundDrawable = new IconicsDrawable(this)
        .icon(FontAwesome.Icon.faw_android)
        .sizeDp(24)
        .color(Color.parseColor("#77000000"));

textView.setCompoundDrawablesWithIntrinsicBounds(compoundDrawable, null, null, null);

I tried that in the sample in the PlaygroundActivity and also got entirely black icons.

[mikepenz]

@rubengees sorry for the delay. Fixed this bug too

[rubengees]

No problem, works great, thanks! 🙂