Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump react-native to 0.76 #3409

Merged
merged 1 commit into from
Jan 20, 2025
Merged

chore: bump react-native to 0.76 #3409

merged 1 commit into from
Jan 20, 2025

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 30, 2024

Description

Bumps react-native to 0.76

Test plan

n/a

@tido64 tido64 mentioned this pull request Oct 30, 2024
Merged
5 tasks
@github-actions github-actions bot added feature: metro This is related to Metro feature: align-deps This is related to align-deps chore Improvements that don't directly affect features feature: third party notices This is related to Third Party Notices feature: cli This is related to CLI feature: jest This is related to Jest feature: sdk This is related to 1RN SDK feature: webapis This is related to the experimental effort around WebAPIs for RN labels Oct 30, 2024
This was referenced Oct 30, 2024
Closed
Closed
Open
@tido64 tido64 force-pushed the tido/bump-react-native branch from 690df3f to 25773a7 Compare October 31, 2024 13:00
@tido64 tido64 force-pushed the tido/bump-react-native branch 4 times, most recently from ced0109 to 7b65f3f Compare January 13, 2025 14:40
@tido64 tido64 marked this pull request as ready for review January 14, 2025 10:35
@tido64 tido64 requested a review from Saadnajmi January 14, 2025 10:35
@tido64 tido64 force-pushed the tido/bump-react-native branch from bb2feaf to bb11ef2 Compare January 20, 2025 12:40
@tido64 tido64 merged commit 7797436 into main Jan 20, 2025
12 checks passed
@tido64 tido64 deleted the tido/bump-react-native branch January 20, 2025 12:56
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Feb 12, 2025
@tido64 @facebook-github-bot
fix: fix @react-native-community/cli-platform-* packages not being …
7926d65 
…found in monorepos (#47308)

Summary:
Fix `react-native-community/cli-platform-*` packages not being found in monorepos.

Note that we are making the assumption that `process.cwd()` returns the project root. This is the same assumption that `react-native-community/cli` makes. Specifically, `findProjectRoot()` has an optional argument that defaults to `process.cwd()`:

- [`findProjectRoot()`](https://github.com/react-native-community/cli/blob/14.x/packages/cli-tools/src/findProjectRoot.ts)
- Which gets called without arguments in [`loadConfig()`](https://github.com/react-native-community/cli/blob/14.x/packages/cli-config/src/loadConfig.ts#L89)
- `loadConfig()` gets called from [`setupAndRun()`](https://github.com/react-native-community/cli/blob/14.x/packages/cli/src/index.ts#L196), also without project root set

As far as I can see, the project root argument is only ever used in tests.

## Changelog:

[GENERAL] [FIXED] - Fix `react-native-community/cli-platform-*` packages not being found in monorepos

Pull Request resolved: #47308

Test Plan:
1. Clone/check out this branch: microsoft/rnx-kit#3409
2. Cherry-pick #47304
3. Cherry-pick #47308
4. Run `react-native config` inside `packages/test-app`
5. Verify that `projects` is populated

**Before:**

```js
  "healthChecks": [],
  "platforms": {},
  "assets": [],
  "project": {}
}
```

**After:**

```js
  "healthChecks": [],
  "platforms": {
    "ios": {},
    "android": {}
  },
  "assets": [],
  "project": {
    "ios": {
      "sourceDir": "/~/packages/test-app/ios",
      "xcodeProject": {
        "name": "SampleCrossApp.xcworkspace",
        "path": ".",
        "isWorkspace": true
      },
      "automaticPodsInstallation": false,
      "assets": []
    },
    "android": {
      "sourceDir": "/~/packages/test-app/android",
      "appName": "app",
      "packageName": "com.msft.identity.client.sample.local",
      "applicationId": "com.msft.identity.client.sample.local",
      "mainActivity": "com.microsoft.reacttestapp.MainActivity",
      "assets": []
    }
  }
}
```

Reviewed By: cortinico

Differential Revision: D69465533

Pulled By: robhogan

fbshipit-source-id: 3d6cf32752a7a41d9c7e84f35b0f26ae7d7a971f
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Feb 14, 2025
@tido64 @facebook-github-bot
fix: fix @react-native-community/cli not being found in pnpm setups (…
a672a4d 
…#47304)

Summary:
Fix `react-native-community/cli` not being found in pnpm setups

## Changelog:

[GENERAL] [FIXED] - Fix `react-native-community/cli` not being found in pnpm setups

Pull Request resolved: #47304

Test Plan:
1. Clone/check out this branch: microsoft/rnx-kit#3409
2. Run `yarn react-native config`

Reviewed By: cortinico

Differential Revision: D65209065

Pulled By: robhogan

fbshipit-source-id: 2ceb73ad140b4afe193e879779c2d8a4b9adf3fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoates-ms acoates-ms Awaiting requested review from acoates-ms acoates-ms is a code owner

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

@Saadnajmi Saadnajmi Awaiting requested review from Saadnajmi

Assignees
No one assigned
Labels
chore Improvements that don't directly affect features feature: align-deps This is related to align-deps feature: cli This is related to CLI feature: jest This is related to Jest feature: metro This is related to Metro feature: sdk This is related to 1RN SDK feature: third party notices This is related to Third Party Notices feature: webapis This is related to the experimental effort around WebAPIs for RN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tido64