chore(0.76): fix prepublish script inconsistencies #2411
Merged
+104
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses inconsistencies in the prepublish script by moving the Azure Pipelines checks after the correct tag has been determined. Ensure tag is correctly set on `main`: ``` ~/S/react-native-macos (main) % node .ado/scripts/prepublish-check.mjs --verbose ❌ .ado/templates/npm-publish-steps.yml: 'publishTag' needs to be set to 'nightly' ``` Ensure tag is correctly set for `0.76-stable` (previous): ``` ~/S/react-native-macos (0.76-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 76 ℹ️ Expected npm tag: v0.76-stable ❌ 'release.version.generatorOptions.currentVersionResolverMetadata.tag' must be set to 'v0.76-stable' ❌ Nx Release is not correctly configured for the current branch ``` Ensure tag is correctly set for `0.77-stable` (current): ``` ~/S/react-native-macos (0.77-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 77 ℹ️ Expected npm tag: latest ``` Ensure tag is correctly set for `0.78-stable` (release candidate): ``` ~/S/react-native-macos (0.78-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 78 ℹ️ Expected npm tag: next ❌ 'defaultBase' must be set to '0.78-stable' ❌ 'release.version.generatorOptions.preid' must be set to 'rc' ❌ 'release.version.generatorOptions.currentVersionResolverMetadata.tag' must be set to 'next' ❌ Nx Release is not correctly configured for the current branch ``` Update config for `0.78-stable` (release candidate): ``` ~/S/react-native-macos (0.78-stable) % node .ado/scripts/prepublish-check.mjs --update ❌ 'defaultBase' must be set to '0.78-stable' ❌ 'release.version.generatorOptions.preid' must be set to 'rc' ❌ 'release.version.generatorOptions.currentVersionResolverMetadata.tag' must be set to 'next' ~/S/react-native-macos (0.78-stable) [1]% node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 78 ℹ️ Expected npm tag: next ❌ .ado/templates/npm-publish-steps.yml: 'publishTag' needs to be set to 'next' ``` Mark `0.78-stable` stable: ``` ~/S/react-native-macos (0.78-stable) % node .ado/scripts/prepublish-check.mjs --verbose --tag latest --update ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 78 ℹ️ Expected npm tag: latest ❌ 'defaultBase' must be set to '0.78-stable' ~/S/react-native-macos (0.78-stable) [1]% node .ado/scripts/prepublish-check.mjs --verbose --tag latest ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 78 ℹ️ Expected npm tag: latest ```
## Summary: When demoting a stable branch, we need to create a new tag. Nx won't be able to find it on npm and should have a fallback. For all other branches, we don't want to use the fallback in case something fails. ## Test Plan: `main`: ``` ~/S/react-native-macos (main) % node .ado/scripts/prepublish-check.mjs --verbose ##vso[task.setvariable variable=publish_react_native_macos]1 ``` `0.76-stable`: ``` ~/S/react-native-macos (0.76-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 76 ℹ️ Expected npm tag: v0.76-stable ❌ 'release.version.generatorOptions.currentVersionResolverMetadata.tag' must be set to 'v0.76-stable' ❌ 'release.version.generatorOptions.fallbackCurrentVersionResolver' must be set to 'disk' ❌ Nx Release is not correctly configured for the current branch ``` `0.77-stable`: ``` ~/S/react-native-macos (0.77-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 77 ℹ️ Expected npm tag: latest ❌ 'release.version.generatorOptions.fallbackCurrentVersionResolver' must be unset ❌ Nx Release is not correctly configured for the current branch ``` `0.78-stable`: ``` ~/S/react-native-macos (0.78-stable) % node .ado/scripts/prepublish-check.mjs --verbose ℹ️ react-native-macos@latest: 77 ℹ️ Current version: 78 ℹ️ react-native-macos@next: 76 ℹ️ Expected npm tag: next ❌ 'defaultBase' must be set to '0.78-stable' ❌ 'release.version.generatorOptions.preid' must be set to 'rc' ❌ 'release.version.generatorOptions.currentVersionResolverMetadata.tag' must be set to 'next' ❌ 'release.version.generatorOptions.fallbackCurrentVersionResolver' must be unset ❌ Nx Release is not correctly configured for the current branch ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2410 to 0.76-stable. I'm also updating the nx config tag.