Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visionOS] Bring back missing ScrollView prop converters #2091

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

In #2019 , we ifdefed out some props that were actually valid on visionOS, namely UIScrollViewContentInsetAdjustmentBehavior and UIScrollViewIndicatorStyle. Let's bring them back by adjusting the ifdefs

Changelog:

[VISIONOS] [FIXED] - Bring back missing ScrollView prop converters

Test Plan:

CI should pass. visionOS should compile locally.

@Saadnajmi Saadnajmi enabled auto-merge (squash) March 8, 2024 08:29
@Saadnajmi Saadnajmi merged commit b53a6d4 into microsoft:main Mar 8, 2024
16 checks passed
@Saadnajmi Saadnajmi deleted the scrollview branch March 8, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants