Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visionOS] Followup fixes #2060

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[visionOS] Followup fixes #2060

merged 1 commit into from
Jan 30, 2024

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

Some followup fixes to #2019 :

  • Exclude RCTUISecureTextField from visionOS. This is a macOS specific file
  • Fix a mismatching ifdef, where some code inside #if !TARGET_OS_OSX called code only defined in #if TARGET_OS_IOS. This is not needed to be back ported to 0.73 and 0.72 as their corresponding PRs already had this fix.

Test Plan:

CI should pass

@Saadnajmi Saadnajmi requested a review from a team as a code owner January 29, 2024 23:11
@Saadnajmi Saadnajmi merged commit f712c20 into microsoft:main Jan 30, 2024
16 checks passed
@Saadnajmi Saadnajmi deleted the fixes branch February 18, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants