Update RCTUITextView to use the systemFontSize for macOS #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
approved these changes
May 31, 2023
Saadnajmi
reviewed
May 31, 2023
harrieshin
approved these changes
May 31, 2023
Saadnajmi
approved these changes
May 31, 2023
lyzhan7
added a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
We have a component using RCTUITextView, and the placeholder text looks too big on macOS. The placeholder text font size was hardcoded to 17px (which according to this is the iOS default font size for body text), but for macOS it should be the system font size, i.e. 13px.
Changelog
[macOS] [FIXED] - Update RCTUITextView to use the systemFontSize
Test Plan
Also confirmed from debugging that the font size on macOS is indeed 13px