Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back macOS tintColor implementation #1801

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

During the 71 merge, I accidentally removed a macOS ifdef block that implemented tintColor for macOS. Thanks @ospfranco for catching! Let's add it back by copying it from the 0.68-stable branch :)

Changelog

[MACOS] [FIXED] - Add back macOS tintColor implementation

Test Plan

TintColor went from not working to working:
Screenshot 2023-04-25 at 10 50 59 PM
Screenshot 2023-04-25 at 10 55 38 PM

@Saadnajmi Saadnajmi merged commit f6eb1d8 into microsoft:main Apr 26, 2023
@Saadnajmi Saadnajmi deleted the tintColor branch August 11, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants